[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[Michael Kuron]

Attention is currently required from: N A, Joshua Colp.

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 9:

(4 comments)

File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/c84f3fc0_39ab010e 
PS8, Line 969:                 ; (default: no)
> I think adding a single sentence about what else actually needs to be done in order to do AOC would  […]
The level of AOC support has not changed. chan_pjsip does not emit AMI events, it merely reacts to AOCMessage AMI actions, just like chan_sip used to, but following a standard way of representing AOC in SIP.


File doc/CHANGES-staging/res_pjsip_aoc.txt:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/a7028734_76304afd 
PS8, Line 3: Added res_pjsip_aoc which gives chan_pjsip the ability to send Advice-of-Charge messages
> and receive them
Receiving is not supported.


File res/res_pjsip_aoc.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/c2609ba5_0a113883 
PS8, Line 471: 			ast_channel_name(session->channel));
> You can remove these 2 lines and let the if fall through to below, since there is nothing else befor […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19460/comment/2380fe09_6a052218 
PS8, Line 478: 
> remove extra line of whitespace
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 13:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221031/279e36ca/attachment.html>