[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Michael Kuron.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 8: Code-Review-1

(4 comments)

File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/e67e2e37_8a01d5d2 
PS8, Line 969:                 ; (default: no)
I think adding a single sentence about what else actually needs to be done in order to do AOC would be helpful, e.g. "AOC updates can be sent using the AOCMessage AMI action and AOC received will emit an AMI event" or something like that.

More importantly, manager.c should be updated to reflect the new level of AOC support, for both the AOCMessage AMI action and the emitted AMI events (e.g. adding AOC-S)


File doc/CHANGES-staging/res_pjsip_aoc.txt:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/ff320121_ce6bb40a 
PS8, Line 3: Added res_pjsip_aoc which gives chan_pjsip the ability to send Advice-of-Charge messages
and receive them


File res/res_pjsip_aoc.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/3d19b066_8dc25cf9 
PS8, Line 471: 			ast_channel_name(session->channel));
You can remove these 2 lines and let the if fall through to below, since there is nothing else before the function returns.


https://gerrit.asterisk.org/c/asterisk/+/19460/comment/d89c3582_44d49f8c 
PS8, Line 478: 
remove extra line of whitespace



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Kuron <m.kuron at gmx.de>
Gerrit-Comment-Date: Mon, 31 Oct 2022 13:19:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221031/015b1234/attachment.html>