[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[Michael Kuron]

Attention is currently required from: Joshua Colp.

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 5:

(3 comments)

Patchset:

PS2: 
> There is not. It has to be modified, and an Alembic script created[1] to cover the realtime aspect. […]
Thanks, I figured out how to do the config option.

Adding test coverage will probably take me another day or two. You can already do another round of reviews if you like while I work on that. Also, would it be acceptable to cherry-pick my patch to the 20 branch? It will have test coverage and is fully backward-compatible, so it seems like it would qualify for that.


File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/539fa4b7_dec2bef9 
PS2, Line 1834: 	case AST_CONTROL_AOC:
> Can the framehook return an &ast_null_frame instead as the frame has been handled by it?
Done


File res/res_pjsip_aoc.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/dfd52dcf_ef734a82 
PS2, Line 491: static pj_status_t aoc_outgoing_response(pjsip_tx_data *tdata)
> There's a limited number of pjsip_modules that can exist at any time, so trying to avoid them is bes […]
I fixed it in res_pjsip_session. Please have a look and let me know if the fix looks reasonable to you.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sun, 30 Oct 2022 12:03:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Michael Kuron <m.kuron at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221030/6995bf4a/attachment-0001.html>