[Asterisk-code-review] tcptls: Prevent crash when freeing OpenSSL errors. (asterisk[master])

N A asteriskteam at digium.com
Fri Oct 28 09:14:03 CDT 2022


Attention is currently required from: N A.

Hello Sean Bright, Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19461

to look at the new patch set (#4).

Change subject: tcptls: Prevent crash when freeing OpenSSL errors.
......................................................................

tcptls: Prevent crash when freeing OpenSSL errors.

write_openssl_error_to_log has been erroneously
using ast_free instead of free, which will
cause a crash when MALLOC_DEBUG is enabled since
the memory was not allocated by Asterisk's memory
manager. This changes it to use the actual free
function directly to avoid this.

ASTERISK-30278 #close

Change-Id: Iac8b6468b718075809c45d8ad16b101af21a474d
---
M main/tcptls.c
1 file changed, 19 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/61/19461/4
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19461
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iac8b6468b718075809c45d8ad16b101af21a474d
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 4
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221028/d17c61de/attachment.html>


More information about the asterisk-code-review mailing list