[Asterisk-code-review] res_pjsip: prevent crash on websocket disconnect (asterisk[18])

Richard Mudgett asteriskteam at digium.com
Wed Oct 19 11:20:23 CDT 2022


Attention is currently required from: Michael Bradeen, George Joseph.

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19413 )

Change subject: res_pjsip: prevent crash on websocket disconnect
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19413/comment/69804919_044b2636 
PS2, Line 20: the contact will not be cleaned up properly, see:ASTERISK-29286. As a
You should not reference other issues than what the patch directly fixes with an accurate JIRA tag.  Otherwise, automation will incorrectly close the other issues when this patch is merged.  To avoid the problem you should replace the '-' in the JIRA issue id with '~' or '_'.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Id050fded2247a04d8f0fc5b8a2cf3e5482cb8cee
Gerrit-Change-Number: 19413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 19 Oct 2022 16:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221019/01f1f010/attachment.html>


More information about the asterisk-code-review mailing list