[Asterisk-code-review] res_pjsip_logger: Add method-based logging option. (asterisk[master])

George Joseph asteriskteam at digium.com
Mon Oct 17 06:14:46 CDT 2022


Attention is currently required from: Sean Bright.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19410 )

Change subject: res_pjsip_logger: Add method-based logging option.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File res/res_pjsip_logger.c:

https://gerrit.asterisk.org/c/asterisk/+/19410/comment/7ef9084e_9e105c92 
PS1, Line 166: static int apply_method_filter(const struct pjsip_logger_session *session, const pjsip_method *method)
Might want to make this return a true/false instead of a return code. I.E.  1 for pass and 0 for fail.  I'm OK with it as is if you want though.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19410
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9c8cbb6fc8686ef21190eb42e08bc9a9b147707f
Gerrit-Change-Number: 19410
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 11:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221017/c3e23bd1/attachment.html>


More information about the asterisk-code-review mailing list