[Asterisk-code-review] res_pjsip_parameters: Add custom parameter support. (asterisk[master])

Sean Bright asteriskteam at digium.com
Wed Oct 12 08:16:56 CDT 2022


Attention is currently required from: N A, Joshua Colp, Alexei Gradinari, Stanislav Abramenkov, George Joseph.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18830 )

Change subject: res_pjsip_parameters: Add custom parameter support.
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

File res/res_pjsip_parameters.c:

https://gerrit.asterisk.org/c/asterisk/+/18830/comment/62847958_2a56c7ac 
PS9, Line 94: PARAMETER_HEADER,
            : 	PARAMETER_URI,
Don't use PJSIP_ as a prefix for anything we create. So PJSIP_PARAMETER_HEADER can just be PARAMETER_HEADER and so on.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18830
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428
Gerrit-Change-Number: 18830
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 13:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221012/9c0b2aa6/attachment.html>


More information about the asterisk-code-review mailing list