[Asterisk-code-review] res_pjsip: return all codecs on a re-INVITE without SDP (asterisk[16])

[Henning Westerholt]

Attention is currently required from: Joshua Colp, N A, George Joseph.

Henning Westerholt has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18990 )

Change subject: res_pjsip: return all codecs on a re-INVITE without SDP
......................................................................


Patch Set 8:

(17 comments)

Patchset:

PS8: 
Thanks, done.
For some reasons the Jenkins failed to build the patch set. I have re-uploaded it again but the same result. I was not able to find a meaningful log output that gives a clue about the error (at least not for me).
It just silently fails after this:

20:41:17   +--------- Asterisk Build Complete ---------+
20:41:17   + Asterisk has successfully been built, and +
20:41:17   + can be installed by running:              +
20:41:17   +                                           +
20:41:17   +                make install               +
20:41:17   +-------------------------------------------+
20:41:17  + rm -f 'tests/CI/output/UnitTests/lcov/*.info'
20:41:17  ++ alembic -c config.ini.sample branches
20:41:18  Alembic branches were found for config
20:41:18  539f68bede2c (branchpoint) -> 417c0247fd7e (head) -> ccf795ee535f (head)


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/bc96a31d_82b784ae 
PS6, Line 1286: ;all_codecs_on_empty_reinvite=yes
> This should state what the default behavior is.
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/c6ff0fe2_b9e59069 
PS6, Line 1287:                     ; On reception of a re-INVITE without SDP Asterisk will send an SDP
> You should indicate the default value.
Done


File doc/CHANGES-staging/res_pjsip_all_codecs_on_empty_reinvite_option.txt:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/2efc834f_efcff8ae 
PS6, Line 3: A new option named "all_codecs_on_empty_reinvite" has been added to the
> You should indicate the default value.
Done


File res/res_pjsip/config_global.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/6b349618_f379ae5a 
PS6, Line 57: #define DEFAULT_ALL_CODECS_ON_EMPTY_REINVITE 1
> Default behavior should remain as it was.
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/4e923b1b_2f163ced 
PS6, Line 57: #define DEFAULT_ALL_CODECS_ON_EMPTY_REINVITE 1
> I think the default should be 0 to preserve existing behavior.
Done


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/fa9f2631_ab2048d1 
PS6, Line 2104: yes
> Should be "no".
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/ba9b730d_8dd09ca8 
PS6, Line 2104: 				<configOption name="all_codecs_on_empty_reinvite" default="yes">
> Default should be no.
Done


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/85349789_b9d88a89 
PS6, Line 5078: 1
> Since the SCOPE_ENTER for this function uses level 3, this should be either -1 to use the same level […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/950705b6_9e842928 
PS6, Line 5081: 1
> same
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/42d1bc94_1147b793 
PS6, Line 5085: 1
> same
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/52a8a8e6_23db4a94 
PS6, Line 5087: 1
> same
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/0cc2f657_e97e7411 
PS6, Line 5244: 	ast_trace(1, "session_inv_on_create_offer\n");
> You don't need an ast_trace here since the SCOPE_ENTER prints the same message. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/7322cf63_f8e27744 
PS6, Line 5246: 		return;
> Replace this return with SCOPE_EXIT_RTN("%s: No channel\n", ast_sip_session_get_name(session));  SCO […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/e59c72ef_2b776b14 
PS6, Line 5256: 1
> See above comment about trace level.
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/5a3618bd_8b0f04a8 
PS6, Line 5259: 1
> Same
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/0cdf1286_3e320675 
PS6, Line 5279: 		return;
> You can remove the return since that's what SCOPE_EXIT_RTN does.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148
Gerrit-Change-Number: 18990
Gerrit-PatchSet: 8
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 18:47:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221010/dde22019/attachment-0001.html>