[Asterisk-code-review] func_callerid: Warn about invalid redirecting reason. (asterisk[master])

[N A]

Attention is currently required from: George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19602 )

Change subject: func_callerid: Warn about invalid redirecting reason.
......................................................................


Patch Set 1:

(1 comment)

File funcs/func_callerid.c:

https://gerrit.asterisk.org/c/asterisk/+/19602/comment/a27674f5_1c9712a1 
PS1, Line 1614: LOG_ERROR
> Should probably be a warning instead of an error since the set will actually succeed and the call wi […]
I only did it this way for consistency with the other log messages in this file - they all use LOG_ERROR instead of LOG_WARNING.

Do you want me to change them all to LOG_WARNING while I'm at it? That way at least it's consistent.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19602
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic341f5d5f7303b6f1115549be64db58a85944f5a
Gerrit-Change-Number: 19602
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 28 Nov 2022 12:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221128/74e79f1e/attachment-0001.html>