[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[20])

[Joshua Colp]

Attention is currently required from: Michael Kuron.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19532 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 3:

(1 comment)

File res/res_pjsip_aoc.c:

https://gerrit.asterisk.org/c/asterisk/+/19532/comment/99b8c7a7_5aa1afc3 
PS3, Line 183: 	pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "AOC", 2048, 512);
> How do I do that, ast_sip_push_task_wait_serializer? […]
ast_sip_push_task_wait_serializer will push the task and wait, while ast_sip_push_task is asynchronous.

I think this should be done asynchronously or else you may introduce a possible deadlock, as I believe the channel lock is held while this is called and unlocking it may not be the best.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19532
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19532
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Kuron <m.kuron at gmx.de>
Gerrit-Comment-Date: Thu, 24 Nov 2022 18:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Michael Kuron <m.kuron at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/8f608ec6/attachment.html>