[Asterisk-code-review] res_pjsip: Fix path usage in case dialing with '@' (asterisk[18])

Igor Goncharovsky asteriskteam at digium.com
Thu Nov 24 09:49:50 CST 2022


Attention is currently required from: Joshua Colp, N A.

Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19471 )

Change subject: res_pjsip: Fix path usage in case dialing with '@'
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> This code has an assumption that a session will always have a contact. This is incorrect. […]
Thank you for pointing this. Also I have left unused endpoint in find_aor().



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19471
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3f2c42a583578c94397b113e32ca3ebf2d600e13
Gerrit-Change-Number: 19471
Gerrit-PatchSet: 4
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 15:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/7835e74e/attachment-0001.html>


More information about the asterisk-code-review mailing list