[Asterisk-code-review] channel.c: Preserve tone playback on masquerades. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19572 )

Change subject: channel.c: Preserve tone playback on masquerades.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/19572/comment/89f28ee9_c2109803 
PS1, Line 7154: 		 * then it makes sense to move the generator over.
Have you gone through the history to understand why things were written this way in the first place? Secondly, this merely moves the generator file descriptor. Is the generatordata moved as well somewhere else? If not, that means that it's not really moving the generator completely.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4753d465bd4d5bb7fe205918e0f22b95a5e869e1
Gerrit-Change-Number: 19572
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 10:33:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/a43a40da/attachment-0001.html>