[Asterisk-code-review] pbx_builtins: Allow Answer to return immediately. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Nov 24 03:42:22 CST 2022


Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19561 )

Change subject: pbx_builtins: Allow Answer to return immediately.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File main/pbx_builtins.c:

https://gerrit.asterisk.org/c/asterisk/+/19561/comment/05d3494d_68495fa5 
PS1, Line 59: 						<para>Answer the channel immediately without waiting for media.</para>
"Raw answer" is an internal implementation detail name. It's meaningless to a user unfamiliar with the code, even I went "why r" on reading. I think it should be a different option such as "i" for immediate.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19561
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id59cd340c44b8b8b2384c479e17e5123e917cba4
Gerrit-Change-Number: 19561
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 09:42:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/9bba2219/attachment-0001.html>


More information about the asterisk-code-review mailing list