[Asterisk-code-review] streams: Ensure that stream is closed in ast_stream_and_wait on error (asterisk[master])

[N A]

Attention is currently required from: Peter Fern.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19574 )

Change subject: streams:  Ensure that stream is closed in ast_stream_and_wait on error
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
It may also be worth adding a \note in file.h that if failure is encountered, the stream will automatically be closed.

> Callers do not typically check the return code

Is there any problem if callers do? Are there any instances of checking the returning code and calling stopstream that could now be removed?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19574
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie46b67314590ad75154595a3d34d461060b2e803
Gerrit-Change-Number: 19574
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Fern <asterisk at obfusc8.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Peter Fern <asterisk at obfusc8.org>
Gerrit-Comment-Date: Tue, 22 Nov 2022 13:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221122/89383e75/attachment.html>