[Asterisk-code-review] res_pjsip: Update contact_user to point out default (asterisk[master])

[Marcel Wagner]

Attention is currently required from: Joshua Colp, George Joseph.

Marcel Wagner has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19569 )

Change subject: res_pjsip: Update contact_user to point out default
......................................................................


Patch Set 4:

(2 comments)

Patchset:

PS2: 
> Does the same default apply to "contact_user" in the registration object?
If you mean the outbound registration, in that case yes but this seems to be already pointed out, however the contact_user field on the extension object seems to default to "asterisk" (at least in my testing). Do you happen to know where this defaults comes from?


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/19569/comment/ef30d994_f4c0db52 
PS2, Line 1314: 					<synopsis>Force the user on the outgoing Contact header to this value.</synopsis>
> I'd keep the description you had in the original patch as well as adding the 'default="s"'. […]
Did this for the outbound registration object since that is the correct documentation.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19569
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I61f24fb9164e4d07e05908a2511805281874c876
Gerrit-Change-Number: 19569
Gerrit-PatchSet: 4
Gerrit-Owner: Marcel Wagner <mwagner at sipgate.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 14:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221121/6d1d3d82/attachment.html>