[Asterisk-code-review] res_pjsip: Update contact_user to point out default (asterisk[master])

[George Joseph]

Attention is currently required from: Marcel Wagner, Joshua Colp.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19569 )

Change subject: res_pjsip: Update contact_user to point out default
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
Does the same default apply to "contact_user" in the registration object?


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/19569/comment/69592771_7a1cc53e 
PS2, Line 1314: 					<synopsis>Force the user on the outgoing Contact header to this value.</synopsis>
I'd keep the description you had in the original patch as well as adding the 'default="s"'.  You should also change the entry in configs/samples/pjsip.conf.sample.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19569
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I61f24fb9164e4d07e05908a2511805281874c876
Gerrit-Change-Number: 19569
Gerrit-PatchSet: 2
Gerrit-Owner: Marcel Wagner <mwagner at sipgate.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Marcel Wagner <mwagner at sipgate.de>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 12:07:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221121/ad202b95/attachment.html>