[Asterisk-code-review] res_pjsip: Fix double Route headers in OPTIONS (asterisk[16])

[Igor Goncharovsky]

Attention is currently required from: Sean Bright, George Joseph.

Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19211 )

Change subject: res_pjsip:  Fix double Route headers in OPTIONS
......................................................................


Patch Set 3:

(1 comment)

File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/19211/comment/9e848d2d_79b78e1b 
PS3, Line 1226: 	if (pjsip_method_cmp(method, &pjsip_options_method)) {
> Is there an easy way to check if we've already added a Route header and if we have, simply skip addi […]
In this case according to config design in case of sending options to the aor's contact we should use only aor proxy and should not use endpoint outbound proxy.

Second, in pjsip_options - we first call ast_sip_create_request (and set proxy from endpoint), after that - set proxy from aor. 

I could suggest adding an additional option to ast_sip_create_request and create_out_of_dialog_request that would point if endpint proxy shold be added to request. Would it be better solutiuon then used currently?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19211
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic43137cfcc468791bf4891ec9792bdb45043a5dc
Gerrit-Change-Number: 19211
Gerrit-PatchSet: 3
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Sun, 20 Nov 2022 15:21:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221120/30f2e361/attachment.html>