[Asterisk-code-review] res_pjsip_rfc3326: Add SIP causes support for RFC3326 (asterisk[18])

[N A]

Attention is currently required from: Igor Goncharovsky.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19570 )

Change subject: res_pjsip_rfc3326: Add SIP causes support for RFC3326
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19570/comment/3818ab14_6c5e2b85 
PS1, Line 9: Add ability to set HANGUPCAUSE when SIP causecode sent in BYE (additionaly to currently supported Q.850).
additionally


File res/res_pjsip_rfc3326.c:

https://gerrit.asterisk.org/c/asterisk/+/19570/comment/4c5e4d67_032804f5 
PS1, Line 41: 
This function is duplicated from here: https://github.com/asterisk/asterisk/blob/31b3addce7b5389125e9a1f6ec11614f54a98c45/channels/chan_pjsip.c#L2876

I think it should be made public in a single place to avoid duplication.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19570
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3f55622dc680ce713a2ffb5a458ef5dd39fcf645
Gerrit-Change-Number: 19570
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Comment-Date: Fri, 18 Nov 2022 15:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221118/c1ab42ec/attachment.html>