[Asterisk-code-review] chan_alsa: Remove deprecated module. (asterisk[master])
Michael Bradeen
asteriskteam at digium.com
Thu Nov 17 09:49:49 CST 2022
Attention is currently required from: N A, Joshua Colp.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19564 )
Change subject: chan_alsa: Remove deprecated module.
......................................................................
Patch Set 3:
(2 comments)
File channels/chan_console.c:
https://gerrit.asterisk.org/c/asterisk/+/19564/comment/1046e017_0205ce06
PS2, Line 38: * including ALSA and OSS, may replace the deprecated chan_alsa and chan_oss.
> This is still forward looking verbiage, even though it's already happened. […]
Done
https://gerrit.asterisk.org/c/asterisk/+/19564/comment/4278df0e_1f194f30
PS2, Line 39: * However, before that can be done, it needs to *at least* have all of the
> Since this has been done anyways, I think this comment should be updated to make it clear that chan_ […]
Done
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19564
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5c8afb781528afdf55d237e3bffa5e4a862ae8c7
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 17 Nov 2022 15:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221117/30fcc5ee/attachment.html>
More information about the asterisk-code-review
mailing list