[Asterisk-code-review] res_agi: Respect "transmit_silence" option for "RECORD FILE". (asterisk[18])

N A asteriskteam at digium.com
Wed Nov 16 06:25:22 CST 2022


Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19567 )

Change subject: res_agi: Respect "transmit_silence" option for "RECORD FILE".
......................................................................


Patch Set 1:

(1 comment)

File res/res_agi.c:

https://gerrit.asterisk.org/c/asterisk/+/19567/comment/063f343b_497ca4a9 
PS1, Line 3000: 				if (silgen)
> Yes. Yes. This is a minor change, so I kept it minor and in line with what is around it.
Makes sense, should there be a CHANGES entry if it's a behavior change? Or is it purely considered a bug fix? JIRA's not loading right now which is why I ask.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19567
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib3a85601ff35d1b904f836691bad8a4b7e957174
Gerrit-Change-Number: 19567
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 12:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221116/47424ff9/attachment.html>


More information about the asterisk-code-review mailing list