[Asterisk-code-review] chan_alsa: Remove deprecated module. (asterisk[master])

N A asteriskteam at digium.com
Tue Nov 15 07:27:48 CST 2022


Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19564 )

Change subject: chan_alsa: Remove deprecated module.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
Here is one you forgot:

menuselect/test/menuselect-tree:<member name="chan_alsa" displayname="ALSA Console Channel Driver" remove_on_change="channels/chan_alsa.o channels/chan_alsa.so">

Also, maybe we can update chan_console to remove the comments about chan_alsa?

* \note Some of the code in this file came from chan_oss and chan_alsa.
*       chan_alsa, Matthew Fredrickson <creslin at digium.com>
* including ALSA and OSS, this may someday deprecate chan_alsa and chan_oss.

Both chan_alsa and chan_oss are deprecated/removed, so the comment about "someday deprecating" could be removed since that has now been done.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19564
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5c8afb781528afdf55d237e3bffa5e4a862ae8c7
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 15 Nov 2022 13:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221115/c3cf967d/attachment.html>


More information about the asterisk-code-review mailing list