[Asterisk-code-review] xmldoc: Allow XML docs to be reloaded. (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Joshua Colp.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19474 )

Change subject: xmldoc: Allow XML docs to be reloaded.
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> module load already expects <module name> as the next argument, so I'm not sure how this could be readily combined into that CLI command.
> 
> It is a bit clunky, but this is admittedly an edge case that likely nobody besides developers would encounter, and even then, only rarely. If a user knows this needs to be done then they would do it; if a user does not already know that the xmldocs need to be reloaded, then I don't really see how having a parameter to do that is going to improve the user experience, since they wouldn't know to do that.

Sorry, I meant...
"module load <module_name> [ with xmldoc ]" so the "with xmldoc" is optional at the end.

> Maybe we can update the warning messages wherever modules could fail to load to also say "If this module was recently built, run xmldoc reload and then load the module again"? That would probably have the most impact, since it makes the warning actionable on the off chance somebody gets it.

That'll work but the updated command would also be helpful if you can do it.  If not, that's fine.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19474
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4f265b0e5517e757c5453a0f241201a5788d3a07
Gerrit-Change-Number: 19474
Gerrit-PatchSet: 4
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 11 Nov 2022 12:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221111/49c34742/attachment-0001.html>