[Asterisk-code-review] res_pjsip_session.c: Map empty extensions in INVITEs to s. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19417 )

Change subject: res_pjsip_session.c: Map empty extensions in INVITEs to s.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/19417/comment/b3dc0545_2f3bf1ee 
PS1, Line 3695: 		ast_exists_extension(NULL, session->endpoint->context, S_OR(session->exten, "s"), 1, NULL)) {
> I think this is the wrong place to solve this. […]
Hi Josh, could you please clarify what you meant exactly?
I'm interpreting this as further up in this function, checking something about the ruri variable - or maybe if (ast_strlen_zero(session->exten)) near the top? Or did you mean a function before it gets to this function?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19417
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0861a405cd49bbbf532b52f7b47f0e2810832590
Gerrit-Change-Number: 19417
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 11 Nov 2022 01:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221111/29cb5af0/attachment.html>