[Asterisk-code-review] res_pjsip_parameters: Add custom parameter support. (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Joshua Colp, Alexei Gradinari, Stanislav Abramenkov.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18830 )

Change subject: res_pjsip_parameters: Add custom parameter support.
......................................................................


Patch Set 9:

(1 comment)

Patchset:

PS9: 
> It's not just header parameters though, it's both header parameters and URI parameters (hence the parameter_type argument), hence the more generic name (see Sean's response).

I'm using HEADER in the generic sense, not specific to parameters.

> 
> Also, Josh said earlier this should be a separate module not in res_pjsip_header_funcs, so I'm getting mixed messages...

I talked to Josh and he's OK with it going into res_pjsip_header_funcs as long as I agree to maintain it. 😊



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18830
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428
Gerrit-Change-Number: 18830
Gerrit-PatchSet: 9
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 09 Nov 2022 13:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221109/db0593c1/attachment.html>