[Asterisk-code-review] manager: AOC-S support for AOCMessage (asterisk[master])

Michael Kuron asteriskteam at digium.com
Sat Nov 5 10:28:13 CDT 2022


Attention is currently required from: N A, Joshua Colp.

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19473 )

Change subject: manager: AOC-S support for AOCMessage
......................................................................


Patch Set 2:

(1 comment)

File main/manager.c:

https://gerrit.asterisk.org/c/asterisk/+/19473/comment/ec806b25_614f2148 
PS1, Line 1125: 				<para>Channel name to generate the AOC message on.</para>
> Even though it's not required for AOC-S, could we add a note that it is required for D and E? Just s […]
Done. This is not actually related to AOC-S. I removed the required attribute here because only either Channel or ChannelPrefix is required. Added a note to make this clear.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19473
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I051b778f8c862d3b4794d28f2f3d782316707b08
Gerrit-Change-Number: 19473
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 05 Nov 2022 15:28:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221105/d5762961/attachment.html>


More information about the asterisk-code-review mailing list