[Asterisk-code-review] xmldoc: Allow XML docs to be reloaded. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19474 )

Change subject: xmldoc: Allow XML docs to be reloaded.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File main/xmldoc.c:

https://gerrit.asterisk.org/c/asterisk/+/19474/comment/7d97b286_84d441ce 
PS2, Line 3014: 	xmldoc_purge_documentation();
There is an existing comment in the code:

 * \note A RWLIST is a sufficient container type to use here for now.
 *       However, some changes will need to be made to implement ref counting
 *       if reload support is added in the future.

Has the API and its possible/current usage been examined to see if this comment is still relevant, and if this is actually safe operation to perform? Does the API allow retrieval of things without a reference such that if a reload occurred, those would then become invalid and cause a crash?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19474
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4f265b0e5517e757c5453a0f241201a5788d3a07
Gerrit-Change-Number: 19474
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Sat, 05 Nov 2022 13:04:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221105/3d1bf005/attachment.html>