[Asterisk-code-review] chan_rtp: Make usage of ast_rtp_instance_get_local_address clearer (asterisk[18])
Joshua Colp
asteriskteam at digium.com
Wed Nov 2 08:28:49 CDT 2022
Attention is currently required from: George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19465 )
Change subject: chan_rtp: Make usage of ast_rtp_instance_get_local_address clearer
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File channels/chan_rtp.c:
https://gerrit.asterisk.org/c/asterisk/+/19465/comment/286ca6aa_d0911125
PS1, Line 232:
I don't think these should be set. They don't serve any value, they're not an address that can be used for something outside to send to Asterisk.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19465
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I872ac49477100f4eb33891d46efc6ca21ec81aa4
Gerrit-Change-Number: 19465
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 13:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221102/9560fdd5/attachment.html>
More information about the asterisk-code-review
mailing list