[Asterisk-code-review] translate.c: Prefer better codecs upon translate ties. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Greg Brown, George Joseph, Kevin Harwell.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15953 )

Change subject: translate.c: Prefer better codecs upon translate ties.
......................................................................


Patch Set 7:

(6 comments)

Patchset:

PS6: 
> > Making a fixed list means it is inherently fixed, while codecs and formats can be dynamically crea […]
Done


File doc/UPGRADE-staging/translate.txt:

https://gerrit.asterisk.org/c/asterisk/+/15953/comment/3f10584d_5dad4847 
PS5, Line 4: cost ties will now be broken by picking the better quality
> A user doesn't know what translation costs are or what a cost tie is. […]
Done


File main/codec_builtin.c:

https://gerrit.asterisk.org/c/asterisk/+/15953/comment/40df5422_f046be25 
PS6, Line 300: 	.quality = 100, /* On par with ulaw */
> Given that slin is 16 bit shouldn't this be higher than ulaw?
Done


https://gerrit.asterisk.org/c/asterisk/+/15953/comment/a776aafd_b4a60822 
PS6, Line 316: 	.quality = 100,
> Given that the sample rate > 8000 and it's 16 bit shouldn't ALL the SLINs be higher than ulaw?
Done


https://gerrit.asterisk.org/c/asterisk/+/15953/comment/58fa21a8_3cd4e709 
PS6, Line 623: 	.quality = 40,
> The qualities assigned are loosely based on these definitions: https://github. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/15953/comment/0050d6ae_9caa85dc 
PS6, Line 889: 	.samples_count = silk_samples,
> They didn't appear in chan_iax2 so I left them alone for now, since translation ties are probably li […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4b7297e1baca7aac14fe4a3c7538e18e2dbe9fd6
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 7
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-CC: Greg Brown <gbrown1002000 at yahoo.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Greg Brown <gbrown1002000 at yahoo.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221102/bd85b0b8/attachment.html>