[Asterisk-code-review] features: Add transfer initiation options. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue May 31 07:22:23 CDT 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18356 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 3:

(1 comment)

File main/features_config.c:

https://gerrit.asterisk.org/c/asterisk/+/18356/comment/8ed41e29_85d3834f 
PS3, Line 704: 	if (!cfg->xfer || ast_string_field_init(cfg->xfer, 32) || ast_string_field_init_extended(&cfg, transferannouncesound)) {
> Line numbers still don't line up, but something is off here
I just pulled down the review and the line numbers line up for me.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18356
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18356
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 31 May 2022 12:22:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/22fd2030/attachment.html>


More information about the asterisk-code-review mailing list