[Asterisk-code-review] res_pjsip: allow TLS verification of wildcard cert-bearing servers (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Joshua Colp, N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18572 )

Change subject: res_pjsip: allow TLS verification of wildcard cert-bearing servers
......................................................................


Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18572/comment/cfa90543_37e58d8b 
PS1, Line 21: And the starting wildcard only matches for a single levels
> level (singular).
Done


Patchset:

PS1: 
> Pending approval of https://github. […]
New patch no longer requires changes to pjproject.


File res/res_pjsip/config_transport.c:

https://gerrit.asterisk.org/c/asterisk/+/18572/comment/9f518db4_5d571cf8 
PS1, Line 884: 	} else if (!strcasecmp(var->name, "allow_wildcard_certs")) {
> If this functionality is not supported then allow the option to be present but output an error messa […]
New patch alleviates this.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If0be3fdab2e09c2a66bb54824fca406ebaac3da4
Gerrit-Change-Number: 18572
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 26 May 2022 20:27:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220526/9e071bed/attachment.html>