[Asterisk-code-review] res_geolocation: Add initial markdown for Geolocation wiki pages (asterisk[development/16/geolocation])

[George Joseph]

Attention is currently required from: N A, Joshua Colp, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18360 )

Change subject: res_geolocation:  Add initial markdown for Geolocation wiki pages
......................................................................


Patch Set 2:

(9 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/f9533b47_b281131a 
PS2, Line 10: since I'm going to be offline for a bit.
> Is this commit message still accurate? Either way I feel the last sentence should be replaced with something more substantive about the commit itself.

It's just a temporary commit.


Patchset:

PS2: 
Updates and rebase coming shortly.


File res/res_geolocation/wiki/AsteriskImplementation.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/8da98f62_084d2bf9 
PS2, Line 65: See [RFC6442|Geolocation#rfc6442] for more informatrion.|
> information
Done


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/eab4cec2_e76be1a3 
PS2, Line 134: You'll notice that neither bob nor alice set {{geoloc_outging_call_profile}} because we never want to send location information _to_ them.
> outgoing
Done


File res/res_geolocation/wiki/CivicAddress.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/b3de61ec_67e89fd9 
PS2, Line 1: {toc}
> Missing new line at EOF
Done


File res/res_geolocation/wiki/GML.md:

PS2: 
> Is this file supposed to be empty?

In the temporary commit, yes.  It was just a placeholder there so the links to it resolved.


File res/res_geolocation/wiki/URI.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/c02aacc5_bb87427c 
PS2, Line 10: Passing location descriptions using URIs is fairly simple from an Asterisk perspective.  It does however, require the implementer to establish and maintain infrastructure to handle the serving of those URIs.  Given the critical nature of the information, setting up such infrasstructure is not trivial and is beyond the scope of Asterisk and this documentation.
> infrastructure
Done


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/3c133ab4_8279573f 
PS2, Line 39: Now let's say that Bob has DID {{12125551212}} assigned to him and he makes an outgoping call which is routed to "my-provider".  Asterisk would automatically add the following header to the INVITE:
> outgoing, not outgoping
Done


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/73379055_3ea52a54 
PS2, Line 45: Of course, this is a _very_ simple example that would add the Geolocation header to _all_ calls made via "my-provider".  If you oonly routed emergency calls to "my-provider" this would work fine but you probably don't want to leak location information on non-emergency calls.
> only
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18360
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I85b239776209bff3fc3388cf9b0a322a1764db29
Gerrit-Change-Number: 18360
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 25 May 2022 17:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220525/73415e3c/attachment.html>