[Asterisk-code-review] say: Abort play loop if caller hangs up. (asterisk[master])

N A asteriskteam at digium.com
Mon May 23 15:30:37 CDT 2022


Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18575 )

Change subject: say: Abort play loop if caller hangs up.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> > ...Maybe I'm a bit dense, but I'm not seeing how... […]
I still don't follow... are you referring to the res > 0 case? There's only one while loop, so the break should cause it to return.

It's the same thing with the res < 0 case, break so we return.

Maybe you thought there was a double while loop?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18575
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I55e85be28ee90b48c0fe4ce20ac136a7dbb49f14
Gerrit-Change-Number: 18575
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 23 May 2022 20:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220523/dc6d539a/attachment-0001.html>


More information about the asterisk-code-review mailing list