[Asterisk-code-review] build: fix bininstall launchd issue on cross-platform build (asterisk[master])

Shloime Rosenblum asteriskteam at digium.com
Thu May 19 21:12:56 CDT 2022


Attention is currently required from: Sergey V. Lobanov.
Shloime Rosenblum has uploaded a new patch set (#2) to the change originally created by Sergey V. Lobanov. ( https://gerrit.asterisk.org/c/asterisk/+/18062 )

Change subject: build: fix bininstall launchd issue on cross-platform build
......................................................................

build: fix bininstall launchd issue on cross-platform build

configure script detects /sbin/launchd, but the result of this
check is not used in Makefile (bininstall). Makefile also detects
/sbin/launchd file to decide if it is required to install
safe_asterisk.

configure script correctly detects cross compile build and sets
PBX_LAUNCHD=0

In case of building asterisk on MacOS host for Linux target using
external toolchain (e.g. OpenWrt toolchain), bininstall does not
install safe_asterisk (due to /sbin/launchd detection in Makefile),
but it is required on target (Linux).

This patch adds HAVE_SBIN_LAUNCHD=@PBX_LAUNCHD@ to makeopts.in to
use the result of /sbin/launchd detection from configure script in
Makefile.
Also this patch uses HAVE_SBIN_LAUNCHD in Makefile (bininstall) to
decide if it is required to install safe_asterisk.

ASTERISK-29905 #close

Change-Id: Iff61217276cd188f43f51ef4cdbffe39d9f07f65
---
M Makefile
M makeopts.in
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/62/18062/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18062
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iff61217276cd188f43f51ef4cdbffe39d9f07f65
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 2
Gerrit-Owner: Sergey V. Lobanov <sergey at lobanov.in>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sergey V. Lobanov <sergey at lobanov.in>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220519/69abc5b3/attachment.html>


More information about the asterisk-code-review mailing list