[Asterisk-code-review] cli: Prevent assertions on startup from bad ao2 refs. (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A, Joshua Colp.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18523 )

Change subject: cli: Prevent assertions on startup from bad ao2 refs.
......................................................................


Patch Set 1:

(1 comment)

File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/18523/comment/3a947bfb_9522a8f0 
PS1, Line 1143: 	while (!ast_test_flag(&ast_options, AST_OPT_FLAG_FULLY_BOOTED)) {
> core show channels gets registered with all the CLI builtins here: https://github. […]
I think the builtins_init should be moved even to be after the ast_cli_perms_init(0); call. Seems like all CLI commands should not be allowed to execute until all CLI configs are fully loaded. It appears too at least one or more even depend on that e.g. handle_cli_show_permissions.

Could make sense as well to break the builtins up into separate arrays. True builtins (functions not dependent upon other Asterisk modules (core or otherwise), and then one or more other arrays depending on how granular one wants to be, e.g. channels, loader associated, etc...



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b3cde802876bd738c1b4cf2683bea6ddc615b6
Gerrit-Change-Number: 18523
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 20 May 2022 00:36:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220519/e6984a59/attachment.html>