[Asterisk-code-review] res_pjsip_transport_websocket: Also set the remote name. (asterisk[18.12])

Michael Bradeen asteriskteam at digium.com
Thu May 19 10:45:44 CDT 2022


Michael Bradeen has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/18559 )

Change subject: res_pjsip_transport_websocket: Also set the remote name.
......................................................................

res_pjsip_transport_websocket: Also set the remote name.

As part of PJSIP 2.11 a behavior change was done to require
a matching remote hostname on an established transport for
secure transports. Since the Websocket transport is considered
a secure transport this caused the existing connection to not
be found and used.

We now set the remote hostname and the transport can be found.

ASTERISK-30065

Change-Id: Ia1cdef33e1411f927985b4b852c95e163c080e94
(cherry picked from commit c5c858287a6d7fb17af84e6abd90447afb26eb94)
---
M res/res_pjsip_transport_websocket.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Michael Bradeen: Looks good to me, approved; Approved for Submit



diff --git a/res/res_pjsip_transport_websocket.c b/res/res_pjsip_transport_websocket.c
index 1b882da..5de17b9 100644
--- a/res/res_pjsip_transport_websocket.c
+++ b/res/res_pjsip_transport_websocket.c
@@ -225,6 +225,7 @@
 	pj_sockaddr_parse(pj_AF_UNSPEC(), 0, pj_cstr(&buf, ws_addr_str), &newtransport->transport.local_addr);
 	pj_strdup2(pool, &newtransport->transport.local_name.host, ast_sockaddr_stringify_addr(ast_websocket_local_address(newtransport->ws_session)));
 	newtransport->transport.local_name.port = ast_sockaddr_port(ast_websocket_local_address(newtransport->ws_session));
+	pj_strdup2(pool, &newtransport->transport.remote_name.host, ast_sockaddr_stringify_addr(ast_websocket_remote_address(newtransport->ws_session)));
 
 	newtransport->transport.flag = pjsip_transport_get_flag_from_type((pjsip_transport_type_e)newtransport->transport.key.type);
 	newtransport->transport.dir = PJSIP_TP_DIR_INCOMING;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18559
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18.12
Gerrit-Change-Id: Ia1cdef33e1411f927985b4b852c95e163c080e94
Gerrit-Change-Number: 18559
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-CC: Friendly Automation
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220519/53e5f579/attachment.html>


More information about the asterisk-code-review mailing list