[Asterisk-code-review] app_if: Adds conditional branch applications (asterisk[master])

N A asteriskteam at digium.com
Wed May 18 10:07:24 CDT 2022


Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16121 )

Change subject: app_if: Adds conditional branch applications
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6: 
> How about adding a check of the manager eventfilters and stasis decline list when this module loads  […]
Print a warning about what - that there might be variables set internally when using this module?

Shouldn't this also apply to app_while?

Is there a better approach that should be used, like using a channel datastore?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16121
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 18 May 2022 15:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220518/eb280255/attachment-0001.html>


More information about the asterisk-code-review mailing list