[Asterisk-code-review] chan_dahdi: allow audio to pass during call setup phase (asterisk[18])

[N A]

Attention is currently required from: Sarah Autumn, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17948 )

Change subject: chan_dahdi: allow audio to pass during call setup phase
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

File channels/sig_analog.c:

https://gerrit.asterisk.org/c/asterisk/+/17948/comment/5b69db5b_91eae0f0 
PS5, Line 1247: 	if (p->hearpulsing == 1) {
== 1 isn't necessary.


https://gerrit.asterisk.org/c/asterisk/+/17948/comment/4e8352a4_c20ebee6 
PS5, Line 1248: 		ast_verb(3, "Enqueueing progress frame when dialling has begun in chan %d\n", p->channel);
This should be ast_debug 1, not ast_verb 3.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibcef6e21020ab6e64f16f4761ec1e0e7fce9c260
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 5
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 17 May 2022 19:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220517/b14f4239/attachment.html>