[Asterisk-code-review] res_crypto: Don't load non-regular files in keys directory (asterisk[master])

Philip Prindeville asteriskteam at digium.com
Tue May 17 10:32:40 CDT 2022


Attention is currently required from: George Joseph, Philip Prindeville.
Philip Prindeville has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18533 )

Change subject: res_crypto: Don't load non-regular files in keys directory
......................................................................


Patch Set 12:

(1 comment)

Patchset:

PS12: 
@George Should I add extra logic to (1) enforce file ownership and permissions for the keys, (2) enforce directory ownership and permissions for the parent of the keys (including symlinks), (3) allow following symlinks?

I can do that as a separate issue.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18533
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie77e0648f8b0b1c2159fb24662d1989cfd4cc36d
Gerrit-Change-Number: 18533
Gerrit-PatchSet: 12
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 17 May 2022 15:32:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220517/5048439f/attachment.html>


More information about the asterisk-code-review mailing list