[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[Mark Murawski]

Attention is currently required from: Sean Bright, N A.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 9:

(11 comments)

Patchset:

PS8: 
> Also, might have missed it somewhere, but is there any function to retrieve a list of channels in a  […]
Done


Patchset:

PS9: 
Mostly resolved.

I need to work a bit on inheritance still


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/73f406d0_77e738d7 
PS8, Line 115:                         <para>Example:</para>
> Use proper <example> sections for examples, not a bunch of <para>s. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/708590f7_b5fc9c1c 
PS8, Line 1003: 	.desc = "Gets or sets a channel group variable.\n\
> I think . […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/fe566d59_6a962bb0 
PS8, Line 1171: 	  ast_log(LOG_WARNING, "GROUP_MATCH_LIST_NEXT() called after the last item was already asked for\n");
> Indentation looks off here in this if block
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b119cfb8_ce2c31a2 
PS8, Line 1267: 	.synopsis =
> Same comments here about registering usage and xml docs for these two...
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/2b578dca_b28cca16 
PS8, Line 2447:         category = "";
> needs to be indented
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/f25e35ed_b95eb1a9 
PS8, Line 2517:           return NULL;
> indentation here and in the next if look off
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/c831ff10_4a2fa27a 
PS8, Line 2549: {
> You're using spaces in this function for indentation, it needs to be tabs.
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/9f73e2ba_60536c0a 
PS8, Line 2610: {
> Same here: convert spaces to tabs - this whole blue block here.
Done


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/cdbcc9df_dbd4634c 
PS8, Line 1913: 
> Indentation here doesn't look quite right - appears to be 2 spaces as opposed to a tab.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 9
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 16 May 2022 11:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220516/67ca2c3d/attachment-0001.html>