[Asterisk-code-review] res_crypto: Use EVP API's instead of legacy API's (asterisk[master])

Philip Prindeville asteriskteam at digium.com
Fri May 13 16:39:29 CDT 2022


Attention is currently required from: Sean Bright, Stanislav Abramenkov, George Joseph.
Philip Prindeville has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18534 )

Change subject: res_crypto: Use EVP API's instead of legacy API's
......................................................................


Patch Set 11:

(4 comments)

Patchset:

PS11: 
Thanks for the feedback.  Fixed.


File res/res_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18534/comment/1e5d9479_7aa1bf2a 
PS10, Line 40: #include <openssl/aes.h>            /* for AES_decrypt, AES_encrypt, AES_set... */
> This #include is no longer needed
Done


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/449572f9_4fd3a9dd 
PS10, Line 42: #include <openssl/ssl.h>            /* for NID_sha1, RSA */
> This #include is no longer needed
Done


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/010300d2_e07fce8d 
PS10, Line 44: #include <openssl/sha.h>            /* for SHA1 */
> This #include is no longer needed
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18534
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5c738756de75fd27ebad54be144c0ac6193f21b2
Gerrit-Change-Number: 18534
Gerrit-PatchSet: 11
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 13 May 2022 21:39:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220513/774c9661/attachment-0001.html>


More information about the asterisk-code-review mailing list