[Asterisk-code-review] res_calendar: Prevent assertion if event ends in past. (asterisk[master])

N A asteriskteam at digium.com
Fri May 13 13:43:12 CDT 2022


Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18250 )

Change subject: res_calendar: Prevent assertion if event ends in past.
......................................................................


Patch Set 3:

(1 comment)

File res/res_calendar.c:

https://gerrit.asterisk.org/c/asterisk/+/18250/comment/dc49af3b_5c628997 
PS2, Line 1002: 		if (devstate_sched_end <= 0) { /* if we let this slip by, Asterisk will assert */
> > I doubt anyone else is going to chime in. This code is old and noone has knowledge of it. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18250
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idfb3204d195f350d2575fb4bc72a54a597d6e93c
Gerrit-Change-Number: 18250
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 13 May 2022 18:43:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220513/d8212f36/attachment-0001.html>


More information about the asterisk-code-review mailing list