[Asterisk-code-review] features: Add transfer initiation options. (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell, Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18001 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 4:

(4 comments)

Patchset:

PS4: 
It sounds like master is fine and only 16, 18, and 19 need to be updated.
I've updated the review for 16 accordingly: https://gerrit.asterisk.org/c/asterisk/+/18356


File include/asterisk/features_config.h:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/df2a882e_500311a8 
PS4, Line 76: 		AST_STRING_FIELD(transferannouncesound);
> For the master branch you can do any ABI breakage needed. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/a04f88b2_cfcb689a 
PS4, Line 76: 		AST_STRING_FIELD(transferannouncesound);
> For the master branch you can do any ABI breakage needed. […]
Ack


File main/features_config.c:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/807bd285_74fa81e3 
PS4, Line 915: 		ast_string_field_set(xfer, transferannouncesound, value);
> ast_string_field_init_extended(&cfg_info, transferannouncesound); will be needed here for other bran […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18001
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 13 May 2022 16:51:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220513/deab6927/attachment.html>