[Asterisk-code-review] res_agi: Evaluate dialplan functions and variables in agi exec (asterisk[19])

[Joshua Colp]

Attention is currently required from: Sean Bright, N A, Shloime Rosenblum.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18537 )

Change subject: res_agi: Evaluate dialplan functions and variables in agi exec
......................................................................


Patch Set 7:

(1 comment)

Patchset:

PS7: 
> Can you describe a scenario where it will break existing behavior? Until now you would need to get t […]
It's passed through as an untouched string currently, allowing people to put whatever they want in it without interpretation. I don't know if there are cases of people using it as such where this would break. I can't guarantee there isn't though, and if this change went in it would break them, and they'd have to make changes themselves to fix it. I'm also taking into consideration the fact that it has behaved this way for probably over 20 years at this point. I'm not comfortable altering something which has behaved a certain way for so long.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18537
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19
Gerrit-Change-Id: I669991f540496e7bddd096fec82b52c083036832
Gerrit-Change-Number: 18537
Gerrit-PatchSet: 7
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Thu, 12 May 2022 17:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220512/5fedf6c1/attachment-0001.html>