[Asterisk-code-review] res_agi: Evaluate dialplan functions and variables in agi exec (asterisk[19])

N A asteriskteam at digium.com
Thu May 12 09:42:01 CDT 2022


Attention is currently required from: Shloime Rosenblum.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18537 )

Change subject: res_agi:  Evaluate dialplan functions and variables in agi exec
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18537/comment/409e3056_ce30373a 
PS5, Line 10: variables in agi exec this can be usefull to SAYFILES
s/usefull/useful


https://gerrit.asterisk.org/c/asterisk/+/18537/comment/57524a72_445c59a1 
PS5, Line 11: in Playback and Read.
in or and? SAYFILES is a function separate from the Playback and Read applications


Patchset:

PS5: 
Since this is a behavior change, I think a CHANGES entry is probably useful as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18537
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19
Gerrit-Change-Id: I669991f540496e7bddd096fec82b52c083036832
Gerrit-Change-Number: 18537
Gerrit-PatchSet: 5
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Thu, 12 May 2022 14:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220512/131c8a86/attachment.html>


More information about the asterisk-code-review mailing list