[Asterisk-code-review] res_crypto: Use EVP API's instead of legacy API's (asterisk[master])

[Sean Bright]

Attention is currently required from: Stanislav Abramenkov, George Joseph, Philip Prindeville.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18534 )

Change subject: res_crypto: Use EVP API's instead of legacy API's
......................................................................


Patch Set 10: Code-Review-1

(4 comments)

File res/res_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18534/comment/aeb481ad_223b55ae 
PS10, Line 38: #define OPENSSL_SUPPRESS_DEPRECATED 1
With this line removed, Asterisk builds without warning for me against both OpenSSL 1.1.1f and OpenSSL 3.0.2


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/c3626e0e_56b44a46 
PS10, Line 40: #include <openssl/aes.h>            /* for AES_decrypt, AES_encrypt, AES_set... */
This #include is no longer needed


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/ef5e4d4c_56e37ac7 
PS10, Line 42: #include <openssl/ssl.h>            /* for NID_sha1, RSA */
This #include is no longer needed


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/78960cb4_3160b91b 
PS10, Line 44: #include <openssl/sha.h>            /* for SHA1 */
This #include is no longer needed



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18534
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5c738756de75fd27ebad54be144c0ac6193f21b2
Gerrit-Change-Number: 18534
Gerrit-PatchSet: 10
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Thu, 12 May 2022 14:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220512/8e7fae7a/attachment.html>