[Asterisk-code-review] test: Add test coverage for capture child process output (asterisk[master])

[N A]

Attention is currently required from: Philip Prindeville.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18526 )

Change subject: test: Add test coverage for capture child process output
......................................................................


Patch Set 8:

(1 comment)

File tests/test_capture.c:

https://gerrit.asterisk.org/c/asterisk/+/18526/comment/660d996b_fd1c74ac 
PS8, Line 285: 
Is compatibility potentially a concern here? Are all these utilities guaranteed to be present through pre-req installation, or could they possibly be missing? Does that matter to whether the test passes or not?

Not every system supported by Asterisk has bash or base64, IIRC.
Maybe this isn't an issue, since only dev systems would be running tests anyways, presumably on a common system with all these. At the very least, if there's no reason to use bash, it might be worth changing bash to sh.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18526
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0273e85eeeb6b8e46703f24cd74d84f3daf0a69a
Gerrit-Change-Number: 18526
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 10 May 2022 00:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/82cb3048/attachment.html>