[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 2:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/6a89a215_6273231b 
PS2, Line 2705: 			ast_log(LOG_NOTICE, "Unable to create channel of type '%s' (cause %d - %s)\n",
> There may or may not be anything wrong with it. It depends upon the context and the situation. […]
Ah, I see. Sharing 486 busy for BUSY/DND was a terrible design mistake in SIP, I think, but what can ya do now...

If WARNING is for "something might have gone wrong", there are a lot of log messages that come to mind that indicate that something actually did go wrong, which are currently NOTICEs. For consistency, it would seem to me these should be upgraded to WARNINGs. I've been making a list and will revisit those in the future.

I *think* (but not positive), the only request that would return NULL with BUSY would be DAHDI, since Asterisk wouldn't have any way of directly checking if a device is busy unless it was physically connected or querying the device, checking cached device state, etc. The other such WARNINGs are after the dial itself as you said.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 May 2022 12:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/af28d42c/attachment-0001.html>