[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 2:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/8f3b80bb_a3b439b9 
PS2, Line 2705: 			ast_log(LOG_NOTICE, "Unable to create channel of type '%s' (cause %d - %s)\n",
> Sure, but isn't that what "NOTICE" is for, exactly? "NOTICE" means "something happened". […]
There may or may not be anything wrong with it. It depends upon the context and the situation.

For example I've seen multiple people report issues with an endpoint being busy, because someone set DND on the phone itself. In that case something was wrong - DND was mistakenly set, they weren't receiving calls, stuff wasn't working.

That's why log messages like this are a minefield and why I err on warning.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 May 2022 12:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/8b6a361a/attachment.html>