[Asterisk-code-review] res_calendar: Prevent assertion if event ends in past. (asterisk[master])

[George Joseph]

Attention is currently required from: Joshua Colp, N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18250 )

Change subject: res_calendar: Prevent assertion if event ends in past.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File res/res_calendar.c:

https://gerrit.asterisk.org/c/asterisk/+/18250/comment/72f377cc_79ac7c38 
PS2, Line 1002: 		if (devstate_sched_end <= 0) { /* if we let this slip by, Asterisk will assert */
> I doubt anyone else is going to chime in. This code is old and noone has knowledge of it. The question is: Does it make sense to have the item be scheduled at all if it has already ended? That is the question I don't know the answer to. Maybe it does.

I'd say drop it if it's already ended. It's better than asserting and since it never worked before, it can't make anything worse.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18250
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idfb3204d195f350d2575fb4bc72a54a597d6e93c
Gerrit-Change-Number: 18250
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 09 May 2022 10:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/03b84caa/attachment.html>