[Asterisk-code-review] ari: expose channel driver's unique id to ARI channel resource (asterisk[master])

Moritz Fain asteriskteam at digium.com
Tue May 3 14:31:10 CDT 2022


Attention is currently required from: Joshua Colp, Richard Mudgett.
Moritz Fain has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18413 )

Change subject: ari: expose channel driver's unique id to ARI channel resource
......................................................................


Patch Set 10:

(1 comment)

File rest-api/api-docs/channels.json:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/ef6e8c8e_481f40f7 
PS10, Line 2132: 					"description": "Protocol id from underlying channel driver (i.e. Call-ID for chan_sip/chan_pjsip)."
> I think it should be documented that this will be empty if the underlying channel driver doesn't sup […]
Could do that. What about all those other fields that can be empty?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87
Gerrit-Change-Number: 18413
Gerrit-PatchSet: 10
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 03 May 2022 19:31:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220503/56fe7d0a/attachment.html>


More information about the asterisk-code-review mailing list